Skip to content

combobox add element name for list item child #4348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
Jun 25, 2025
+9 −0
Merged

combobox add element name for list item child #4348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c244ed
feat(combobox): add element name for list item child
PixeledCode Jun 24, 2025
2dc9f2f
feat(combobox): add changeset
PixeledCode Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/perfect-experts-cheat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@twilio-paste/combobox": patch
"@twilio-paste/core": patch
---

[Combobx] add element name for Combobox List Item child
1 change: 1 addition & 0 deletions packages/paste-core/components/combobox/src/styles/ComboboxListboxOption.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ const ComboboxListboxOption = React.forwardRef<HTMLLIElement, ComboboxListboxOpt
backgroundColor={getBackgroundColor(highlighted, selected)}
paddingY="space40"
transition="background-color 150ms ease, color 150ms ease"
element={`${element}_LIST_ITEM_CHILD`}
{...VariantStyles[variant]}
>
<Box as="span">
Expand Down
2 changes: 2 additions & 0 deletions packages/paste-core/components/combobox/stories/Combobox-customization.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ const ShowCustomization: React.FC<React.PropsWithChildren<{ isTestEnvironment: b
COMBOBOX_GROUPNAME: { fontFamily: "fontFamilyText", cursor: "help" },
COMBOBOX_GROUPNAME_TEXT: { fontWeight: "fontWeightLight" },
COMBOBOX_LIST_ITEM: { backgroundColor: "colorBackgroundPrimaryStrong" },
COMBOBOX_LIST_ITEM_CHILD: { backgroundColor: "colorBackgroundPrimary" },
COMBOBOX_LIST_ITEM_TEXT: { color: "colorTextWeakest", fontWeight: "fontWeightBold" },
HELP_TEXT: { color: "colorTextWarningStrong" },
COMBOBOX_PREFIX: { backgroundColor: "colorBackgroundRequired", borderRadius: "borderRadius20" },
Expand All @@ -71,6 +72,7 @@ const ShowCustomization: React.FC<React.PropsWithChildren<{ isTestEnvironment: b
FOO_GROUPNAME: { fontFamily: "fontFamilyText", cursor: "help" },
FOO_GROUPNAME_TEXT: { fontWeight: "fontWeightLight" },
FOO_LIST_ITEM: { backgroundColor: "colorBackgroundPrimaryStrong" },
FOO_LIST_ITEM_CHILD: { backgroundColor: "colorBackgroundPrimary" },
FOO_LIST_ITEM_TEXT: { color: "colorTextWeakest", fontWeight: "fontWeightBold" },
HELP_TEXT: { color: "colorTextWarningStrong" },
FOO_PREFIX: { backgroundColor: "colorBackgroundRequired", borderRadius: "borderRadius20" },
Expand Down
Loading