Add response to post save filter#11
Open
KirkJohnson wants to merge 5 commits intotunapanda:masterfrom
Open
Conversation
This creates an option in the settings page that allows alerts to either be displayed as an alert or written as console.log statements. On a production site the error alerts could ruin user experience so this can be unchecked to give alerts without interferring with UX.
Upstream modified changes on code so this modifies our code to work with the way they changed theirs.
Adds lrs response to h5p-xapi-post-save filter so that if needing to store returned uuid for later voiding are modifying this is possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the LRS response object to the h5p-xapi-post-save filter. The response object contains the uuid which is passed back after being stored. The uuid is needed if you need to make updates or void a statement later so this simply makes the response available as a second parameter in the filter for projects to see and store needed info.