simplify event title HTML entity decoding

Author: cdoyle-temple

app/services/sync_service/events.rb

@@ -147,11 +147,7 @@ def all_day(event)
   end
 
   def event_title(event)
-    if (node = event_xml_node(event)&.at_xpath("//Title"))
-      node.text.tr("\u00A0", " ")
-    elsif (title = event.fetch("Title", nil))
-      CGI.unescapeHTML(title).tr("\u00A0", " ")
-    end
+    Nokogiri::HTML4.fragment(event.fetch("Title", "").to_s).text.tr("\u00A0", " ")
   end
 
   def contact(event)
@@ -212,10 +208,4 @@ def stdout_and_log(message, level: :info)
     @log.send(level, message)
     # @stdout.send(level, message)
   end
-
-  def event_xml_node(event)
-    return if event["xml"].blank?
-
-    Nokogiri::XML(event["xml"])
-  end
 end

spec/services/sync_events_spec.rb

@@ -39,22 +39,16 @@ def self.cache
         expect(subject["title"]).to match(@events.first["Title"])
       end
 
-      it "decodes html entities from the xml title node" do
-        event = @events.first.merge(
-          "Title" => "Refugees & Resettlement",
-          "xml" => "<Event><Title>Refugees &amp; Resettlement</Title></Event>"
-        )
+      it "decodes html entities from the title" do
+        event = @events.first.merge("Title" => "Refugees &amp; Resettlement")
 
         expect(@sync_events.record_hash(event)["title"]).to eq("Refugees & Resettlement")
       end
 
-      it "decodes html entities from the fallback title value when xml title lookup fails" do
-        event = @events.first.merge(
-          "Title" => "Refugees &amp; Resettlement",
-          "xml" => "<Event><Description>Fallback title path</Description></Event>"
-        )
+      it "normalizes non-breaking spaces from the title" do
+        event = @events.first.merge("Title" => "Refugees&nbsp;and&nbsp;Resettlement")
 
-        expect(@sync_events.record_hash(event)["title"]).to eq("Refugees & Resettlement")
+        expect(@sync_events.record_hash(event)["title"]).to eq("Refugees and Resettlement")
       end
 
       it "maps Description to description field" do