Use HTML Unescape On Event Title Fallback

Author: cdoyle-temple

app/services/sync_service/events.rb

@@ -147,7 +147,11 @@ def all_day(event)
   end
 
   def event_title(event)
-    event_xml_node(event)&.at_xpath("//Title")&.text&.tr("\u00A0", " ") || event.fetch("Title", nil)
+    if (node = event_xml_node(event)&.at_xpath("//Title"))
+      node.text.tr("\u00A0", " ")
+    elsif (title = event.fetch("Title", nil))
+      CGI.unescapeHTML(title).tr("\u00A0", " ")
+    end
   end
 
   def contact(event)

spec/services/sync_events_spec.rb

@@ -39,7 +39,7 @@ def self.cache
         expect(subject["title"]).to match(@events.first["Title"])
       end
 
-      it "decodes html entities from the xml title" do
+      it "decodes html entities from the xml title node" do
         event = @events.first.merge(
           "Title" => "Refugees & Resettlement",
           "xml" => "<Event><Title>Refugees &amp; Resettlement</Title></Event>"
@@ -48,6 +48,15 @@ def self.cache
         expect(@sync_events.record_hash(event)["title"]).to eq("Refugees & Resettlement")
       end
 
+      it "decodes html entities from the fallback title value when xml title lookup fails" do
+        event = @events.first.merge(
+          "Title" => "Refugees &amp; Resettlement",
+          "xml" => "<Event><Description>Fallback title path</Description></Event>"
+        )
+
+        expect(@sync_events.record_hash(event)["title"]).to eq("Refugees & Resettlement")
+      end
+
       it "maps Description to description field" do
         expect(subject["description"]).to match(@events.first["Description"])
       end