fix: handle Smoothie Board DSN pin number modifiers#122
Open
EnzoGaillardSystems wants to merge 1 commit intotscircuit:mainfrom
Open
fix: handle Smoothie Board DSN pin number modifiers#122EnzoGaillardSystems wants to merge 1 commit intotscircuit:mainfrom
EnzoGaillardSystems wants to merge 1 commit intotscircuit:mainfrom
Conversation
Skip rotate/mirror/flip modifier lists when extracting pin numbers. Only coerce to number when string is fully numeric (preserves 2@1, GND1). Closes tscircuit#54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #54
Problem
Smoothie Board DSN files contain pin definitions with modifier lists like
(rotate 90)at position 2 in the AST. The existinggetPinNumalways read position 2, so it grabbed the modifier list instead of the actual pin number, causing the conversion to fail.Fix
rotate,mirror,flip) when extracting pin numbers2@1,GND1)Changes
lib/utils/get-pin-number.ts— rewritten pin extraction logicCloses #54