Open
Conversation
Collaborator
|
Does this affect any demo? maybe the videos look different now if they were relying on the default argument |
Collaborator
Author
I would argue that doing this make the demos even more consistent with the videos we show in their README. As you can see in the yolov7 demo when we use this function we use the default value, but in the video in the README there is no label. That is because the video was generated with the old drawing functions, and when we updated the drawing functions we forgot to pass the argument to not draw the labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default value for
draw_labelswas not the same indraw_boxesanddraw_points. For consistency, I think it would be better to have the same default value