maintenance: Separate Code into Separate Files#163
Merged
Conversation
Contributor
Author
|
pre-commit fails on a file I have not changed 😤 |
Contributor
I found that, too. Pre-commit is now using Python 3.14. |
whoisj
force-pushed
the
jwyman/refactor-files
branch
from
2e66c48 to
015d383
Compare
This change breaks the monolithic src/libtorch.cc into multiple files, with a modern separation of classes into separate header and code files.
whoisj
force-pushed
the
jwyman/refactor-files
branch
from
015d383 to
642f74e
Compare
yinggeh
reviewed
Oct 31, 2025
| @@ -0,0 +1,106 @@ | |||
| // Copyright 2019-2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | |||
Contributor
There was a problem hiding this comment.
Prefer string_utils.hh or simply utils.hh
Renamed 'string_utilities.*' to 'string_utils.*' as requested.
yinggeh
approved these changes
Nov 3, 2025
mc-nv
reviewed
Nov 5, 2025
| #include "model_instance_state.hh" | ||
| #include "model_state.hh" | ||
| #include "naming_convention.hh" | ||
| #include "string_utilities.hh" |
Contributor
There was a problem hiding this comment.
At least, this header file is not defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change breaks the monolithic src/libtorch.cc into multiple files, with a modern separation of classes into separate header and code files.
No actual code changes were made besides the separation of the code into multiple files.