This repository was archived by the owner on Feb 17, 2025. It is now read-only.
[baking-with-ledger] handles feedback#526
Merged
timothymcmackin merged 3 commits intotrilitech:mainfrom Jan 28, 2025
Merged
Conversation
|
@spalmer25 is attempting to deploy a commit to the Trili Tech Team on Vercel. A member of the Team first needs to authorize it. |
spalmer25
changed the title
Step 2: Set up a baker account
Because readers were confused, the `Set up a baker account` step was no longer clear enough.
Because it seems bakers mostly have main key on their ledger
spalmer25
force-pushed
the
palmer@functori@make-baking-with-ledger-clearer
branch
from
08078a1 to
a1aabc9
Compare
ajinkyasraj
reviewed
Jan 24, 2025
Co-authored-by: Ajinkya <145996984+ajinkyaraj-23@users.noreply.github.com>
spalmer25
force-pushed
the
palmer@functori@make-baking-with-ledger-clearer
branch
from
b0532d8 to
d437c35
Compare
Contributor
|
@timothymcmackin Can you please review? |
timothymcmackin
approved these changes
Jan 27, 2025
Contributor
|
hi @timothymcmackin , Can we merge this branch now? |
Contributor
Yup, merged, thanks for the submission! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some feedback on our
Baking with Ledgertutorial has been received.This PR deals with these comments.
The command to runs for it as been included.