feat(suite-native:) EIP1559 #23637

BrantalikP · 2025-12-04T18:08:57Z

Description

Enable EIP1559 for mobile

Notes for QA

Related Issue

Resolve #16372

Screenshots:

Simulator Screenshot - iPhone 11 - 2025-12-07 at 14 41 01

🔍🖥️ Suite web test results: View in Currents

🔍🖥️ Suite desktop test results: View in Currents

🔍🖥️ Suite native android test results: View in Currents

trezor-bot · 2025-12-05T09:12:02Z

✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

trezor-bot · 2025-12-07T12:56:37Z

✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

tomasklim · 2025-12-09T11:29:39Z

suite-common/wallet-core/src/fees/feesReducer.ts

-        return formatDuration(networkFeeInfo.blockTime * feeLevel.blocks * 60);
+        const networkType = symbol ? getNetworkType(symbol) : null;
+
+        const multiplier = networkType === 'bitcoin' ? 60 : 1;


please explain multiplier by a comment

TomasBoda

Is it intended behavior that when I click on Send max (e.g. $150) and set a custom fee (e.g. $60), the send amount is reduced to $90? I would expect an error message in the fee component that says You don't have enough funds to cover this fee, but maybe I'm mistaken.

TomasBoda

During transaction signing and confirming on Trezor, the send amount and fee amount changed after a few seconds on the mobile screen. I guess there is some recalculation happening, but I believe it shouldn't. Because after this change, Trezor and mobile app were showing different amounts.

I'll try to replicate.

TomasBoda

Minor detail (you may dismiss if not relevant):

In case of Max fee per gas is lower than Max priority fee per gas, both input fields are invalid and both show analogous errors. Wouldn't it be better to show just one error banner below the form? cc @matous-jemelka @shenkys

Also, shouldn't the Confirm custom fee button be in disabled state in case of any erros?

Simulator Screenshot - iPhone 17 Pro - 2025-12-10 at 14 08 55

TomasBoda · 2025-12-10T13:32:50Z

suite-native/transaction-management/src/components/fees/__tests__/FeesContent.comp.test.tsx


    const defaultProps = {
-        selectedFeeLevel: 'normal' as NativeSupportedFeeLevel,
+        selectedFeeLevel: 'normal' as FeeLevelLabel,


Nitpick:

Suggested change

selectedFeeLevel: 'normal' as FeeLevelLabel,

selectedFeeLevel: 'normal' as const,

TomasBoda · 2025-12-10T13:33:19Z

suite-native/transaction-management/src/components/fees/__tests__/FeesContent.comp.test.tsx

    it('should render fee options list when selected fee level is not custom', async () => {
        const { getByTestId } = await renderFeesContent({
-            selectedFeeLevel: 'normal' as NativeSupportedFeeLevel,
+            selectedFeeLevel: 'normal' as FeeLevelLabel,


Is type casting needed here? (similarly in cases below)

TomasBoda · 2025-12-10T13:37:11Z

suite-native/transaction-management/src/components/fees/CustomFee/CustomFeeInputs.tsx

+                    onChangeText={handleFieldChangeValue(FEE_LIMIT_FIELD_NAME, integerTransformer)}
+                />
+            )}
+            {isEip1559Fee ? (


This component is not yet large and complex, but I'd consider creating two new components - one for EIP1559, one for the else branch for better maintainability in the future.

(or at least for the EIP1559 logic)

TomasBoda · 2025-12-10T13:40:23Z

suite-native/transaction-management/src/hooks/fees/useFeeSelection.ts

+        (
+            feeLevel: FeeLevelLabel,
+            customFeePerUnit?: string,
+            customFeeLimit?: string,
+            customMaxFeePerGas?: string,
+            customMaxPriorityFeePerGas?: string,
+        ) => {


Consider passing the props as object, especially when you created the new CustomFeeParams object (almost identical). Also it is more readable when the function is called on other places.

TomasBoda · 2025-12-10T13:41:23Z

suite-native/transaction-management/src/hooks/fees/useFeesForm.ts

            networkFeeInfo,
            symbol: account?.symbol,
            minimalFeeLimit,
+            translate,


Why is translate needed here?

tomasklim · 2025-12-10T17:10:56Z

Please show more decimals for base fee. We need to fix it also for desktop 😬

BrantalikP added the mobile Suite Lite issues and PRs label Dec 4, 2025

BrantalikP force-pushed the feat/native/evm-priority-fees branch from ff612aa to 87ca729 Compare December 5, 2025 09:11

BrantalikP force-pushed the feat/native/evm-priority-fees branch 3 times, most recently from e32b080 to 9697e62 Compare December 7, 2025 12:56

BrantalikP force-pushed the feat/native/evm-priority-fees branch 4 times, most recently from 117e4dd to b8050d4 Compare December 8, 2025 15:48

BrantalikP added 6 commits December 9, 2025 09:53

fix(suite-native): fix NetworkMessageCard key error

1f3c503

feat(suite-native): enable eip1559

7026650

feat(suite-native): add eip1559 standard fee options

b0e074e

feat(suite-native): add eip1559 custom fee inputs

ef8698a

feat(suite-native): create eip1559 custom fee validations

89d1b13

feat(suite-native): add dynamic error msgs to feeFormSchema

9736b84

BrantalikP force-pushed the feat/native/evm-priority-fees branch from b8050d4 to 9736b84 Compare December 9, 2025 08:53

tomasklim reviewed Dec 9, 2025

View reviewed changes

BrantalikP force-pushed the feat/native/evm-priority-fees branch 8 times, most recently from d230002 to d220f38 Compare December 10, 2025 10:10

BrantalikP added 3 commits December 10, 2025 11:27

feat(suite-native): ethereum custom fee ui changes

00e8fc8

feat(suite-native): add support for eip1559 trading custom fee

2f5af3f

fix(suite-native): fix custom fee validation

009c630

fix(suite-native): fix customfee tests

422d2ef

BrantalikP force-pushed the feat/native/evm-priority-fees branch from d220f38 to 422d2ef Compare December 10, 2025 10:27

fix(suite-native): transaction's code cleanup

f9054d5

TomasBoda reviewed Dec 10, 2025

View reviewed changes

TomasBoda requested changes Dec 10, 2025

View reviewed changes

TomasBoda reviewed Dec 10, 2025

View reviewed changes

TomasBoda requested changes Dec 10, 2025

View reviewed changes

BrantalikP marked this pull request as ready for review December 10, 2025 17:11

BrantalikP requested a review from a team as a code owner December 10, 2025 17:11

	selectedFeeLevel: 'normal' as FeeLevelLabel,
	selectedFeeLevel: 'normal' as const,

Uh oh!

feat(suite-native:) EIP1559 #23637

Are you sure you want to change the base?

feat(suite-native:) EIP1559 #23637

Conversation

BrantalikP commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Notes for QA

Related Issue

Screenshots:

Uh oh!

trezor-bot bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trezor-bot bot commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tomasklim Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

TomasBoda left a comment

Choose a reason for hiding this comment

Uh oh!

TomasBoda left a comment

Choose a reason for hiding this comment

Uh oh!

TomasBoda left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TomasBoda Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

TomasBoda Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

TomasBoda Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

TomasBoda Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

TomasBoda Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

tomasklim commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

BrantalikP commented Dec 4, 2025 •

edited

Loading

trezor-bot bot commented Dec 5, 2025 •

edited

Loading

trezor-bot bot commented Dec 7, 2025 •

edited

Loading

TomasBoda left a comment •

edited

Loading