feat(e2e): add send tests for Base transactions #23632
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive end-to-end tests for Base network (EVM chain) transactions, including both custom and standard fee scenarios, along with necessary test infrastructure improvements.
- Adds two E2E tests: one for custom fee transactions and one for standard fee transactions with network confirmation
- Enhances the Fees page object with helper methods to extract standard fee values and configurable decimal precision
- Adds test IDs to transaction detail modal for better testability of confirmed/unconfirmed transaction states
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
packages/suite-desktop-core/e2e/tests/wallet/send-base.test.ts |
New test file implementing comprehensive Base network send transaction tests with custom and standard fee scenarios |
packages/suite-desktop-core/e2e/support/pageObjects/trading/fees.ts |
Enhanced Fees page object with getStandardFeeWorkaround() method, switchToStandard() method, and configurable decimal precision for fee calculations |
packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/BasicTxDetails.tsx |
Added data-testid attributes to confirmed/unconfirmed transaction status elements for E2E test targeting |
| tradingPage.fees.calculateEthereumMaxFee({ | ||
| gasLimit, | ||
| maxFeePerGas, | ||
| numberOfDecimasls: 15, |
There was a problem hiding this comment.
Typo in parameter name: "numberOfDecimasls" should be "numberOfDecimals" when calling the method.
| numberOfDecimasls: 15, | |
| numberOfDecimals: 15, |
| const maxFeePerGasRounded = new BigNumber(maxFeePerGas) | ||
| .decimalPlaces(4, BigNumber.ROUND_UP) | ||
| .toFixed(4); | ||
| new BigNumber(maxFeePerGas).decimalPlaces(4, BigNumber.ROUND_UP); |
There was a problem hiding this comment.
This line appears to be dead code - it creates a new BigNumber but doesn't assign it to anything or use the result. The calculation is already performed on the previous lines and assigned to maxFeePerGasRounded.
| new BigNumber(maxFeePerGas).decimalPlaces(4, BigNumber.ROUND_UP); |
| calculateEthereumMaxFee({ | ||
| gasLimit, | ||
| maxFeePerGas, | ||
| numberOfDecimasls = 14, |
There was a problem hiding this comment.
Typo in parameter name: "numberOfDecimasls" should be "numberOfDecimals" (missing 'l', extra 's').
| }: { | ||
| gasLimit: string; | ||
| maxFeePerGas: string; | ||
| numberOfDecimasls?: number; |
There was a problem hiding this comment.
Typo in parameter name: "numberOfDecimasls" should be "numberOfDecimals" (missing 'l', extra 's'). This typo appears in both the parameter definition and default value assignment.
authored: Ondra Zik rebased: Martin Cihlar
Description
This PR adds end-to-end tests for sending transactions on the Base network (EVM chain).
Custom fee transaction test: Tests the ability to set custom gas fees (gas limit, max fee per gas, and max priority fee per gas) and verifies all fee-related information displayed on the device emulator.
Standard fee transaction test: Tests a complete send flow with standard fees, including transaction confirmation on the network and verification of the confirmed status in the transaction details modal.
Key changes:
send-base.test.tswith comprehensive tests for Base network transactionsFeespage object with:getStandardFeeWorkaround(): Helper method to extract standard fee values by temporarily switching to custom modeswitchToStandard(): Method to switch back to standard fee modecalculateEthereumMaxFee()with configurable decimal precisiondata-testidattributes to transaction detail modal for better testability of confirmed/unconfirmed statesTest will be only in nightly desktop because on how it has a finite resources.
Nightly Desktop
🔍🖥️ Suite web test results: View in Currents
🔍🖥️ Suite desktop test results: View in Currents