fix for launcher ignoring specified URL#740
Open
jcomeauictx wants to merge 5 commits intotorproject:mainfrom
Open
fix for launcher ignoring specified URL#740jcomeauictx wants to merge 5 commits intotorproject:mainfrom
jcomeauictx wants to merge 5 commits intotorproject:mainfrom
Conversation
Collaborator
|
Thanks for the fix! Please submit it as a MR here if possible since this GitHub repo is only a mirror. |
Author
|
would you be willing to do it? I don't have an account, and the site is
nonfunctional on my phone.
…On Friday, May 9, 2025, AsciiWolf ***@***.***> wrote:
*AsciiWolf* left a comment (torproject/torbrowser-launcher#740)
<#740 (comment)>
Thanks for the fix! Please submit it as a MR here
<https://gitlab.torproject.org/tpo/applications/torbrowser-launcher/-/merge_requests>
if possible since this GitHub repo is only a mirror.
—
Reply to this email directly, view it on GitHub
<#740 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABRUXQYKTVIZJ7W3QXLZTD25SO4BAVCNFSM6AAAAABVHM5JTCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNRWGM4TMNZYHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
John Comeau KE5TFZ WSEE965 ***@***.***> ***@***.***>
http://jc.unternet.net/
"A place for everything, and everything all over the place"
|
Collaborator
|
Sorry, but probably no. I am already overwhelmed with other work tasks and also currently have no easy way to test this. Feel free to keep this PR open. I may take a look in upcoming weeks. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
url_list from launcher was saved during initialization, but was never passed on to the browser.