fix(powershell): handle unavailable Update-Module#1993
Open
niStee wants to merge 1 commit intotopgrade-rs:mainfrom
Open
fix(powershell): handle unavailable Update-Module#1993niStee wants to merge 1 commit intotopgrade-rs:mainfrom
niStee wants to merge 1 commit intotopgrade-rs:mainfrom
Conversation
Contributor
Author
|
Tested with:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
Closes #1443.
This changes the PowerShell module update step to avoid passing
-ForcetoUpdate-Modulewhen--yesis used. Instead, it passes-Confirm:$falseand conditionally addsAcceptLicensewhen the installedUpdate-Modulesupports it.It also checks whether
PowerShellGetcan provideUpdate-Modulebefore running the update. IfUpdate-Moduleis unavailable or cannot be loaded, Topgrade now prints a warning and marks the step as skipped instead of failing with a command-not-found error or reportingOKafter doing no update.This helps Windows PowerShell 5.1 setups where
PowerShellGet/PackageManagementare broken, blocked by cloud-backed module folders, or otherwise cannot be autoloaded.Standards checklist
CONTRIBUTING.mdAI involvement
I used AI assistance while investigating the PowerShell behavior, drafting the code change, and running local checks. I reviewed the changes myself before submitting.