build: add rustfmt and clippy to toolchain components#1992
Closed
niStee wants to merge 1 commit intotopgrade-rs:mainfrom
Closed
build: add rustfmt and clippy to toolchain components#1992niStee wants to merge 1 commit intotopgrade-rs:mainfrom
niStee wants to merge 1 commit intotopgrade-rs:mainfrom
Conversation
Member
|
Can you show that this improves the developer experience? The default components to install include |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
This PR adds
rustfmtandclippyto thecomponentslist inrust-toolchain.toml.Because
CONTRIBUTING.mdrequires contributors to runcargo fmtandcargo clippylocally before submitting a PR, adding them to the toolchain configuration ensures that anyone working on the project will automatically have the correct tools installed viarustup. This improves developer experience without relying on auto-fixing CI or external dependencies.Standards checklist
CONTRIBUTING.mdAI involvement
I consulted an AI assistant to discuss the security implications of auto-fixing formatting in CI. After discovering that CI auto-fixes with PATs introduce security vulnerabilities for outside contributors, the AI suggested making this clean, local toolchain change instead.