Open
Conversation
❌ Deploy Preview for p5-svelte failed.
|
|
Came here to request the same fix. +1 for this PR :) |
Author
|
Hey @rbrdl and @tonyketcham do you have any comments/questions/concerns about this MR? I'm looking into this dependency again today and I would love to get it fixed because that's quite a nice wrapper. I see that the CI checks are all failing and that you have #371 which I think would be fixed with this MR. Let me know if I can be of any help :) |
|
Adding my comment here in hopes of getting this fix into main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building a project with dependencies:
We get the following warning:
This MR reuses the example from the doc for this error to fix the warning and ensure this lib won't break in the future.
Btw thanks for this project it's super convenient 👍