Answer:58#1263
Closed
tsironis13 wants to merge 4 commits intotomalaforge:mainfrom
Closed
Conversation
added 4 commits
March 26, 2025 18:10
github-actions
Bot
added
58
tomalaforge
reviewed
Mar 28, 2025
| @Directive({ | ||
| selector: '[appCardMessage]', | ||
| }) | ||
| export class CardMessageDirective {} |
Owner
There was a problem hiding this comment.
nice, using a directive to avoid magic string is the cherry on top. Nice solution
|
This pull request is stale because it has been open for 15 days with no activity. |
|
This pull request was closed because it has been inactive for 5 days since being marked as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The solution is based on the fact that we cannot include 2 ng-content tags with the same selector. This is an Angular by design constraint. Ng-template tag can be used instead.