fs: implement tokio::fs::symlink via io_uring#7844
Open
tahmid-23 wants to merge 1 commit intotokio-rs:masterfrom
Open
fs: implement tokio::fs::symlink via io_uring#7844tahmid-23 wants to merge 1 commit intotokio-rs:masterfrom
tahmid-23 wants to merge 1 commit intotokio-rs:masterfrom
Conversation
tahmid-23
force-pushed
the
tahmid-23/uring-symlink
branch
from
ef347a8 to
5b5d8f4
Compare
tahmid-23
changed the title
ADD-SP
added
A-tokio
martin-g
reviewed
Jan 9, 2026
|
|
||
| // If io_uring is enabled (and not falling back to the thread pool), | ||
| // the first poll should return Pending. | ||
| let _pending = pin!(fut).poll_unpin(cx); |
Member
There was a problem hiding this comment.
Let's assert that:
Suggested change
| let _pending = pin!(fut).poll_unpin(cx); | |
| assert_pending!(pin!(fut).poll_unpin(cx)); |
| let (done_tx, done_rx) = mpsc::channel(); | ||
| let (workdir, target) = create_tmp_dir(); | ||
|
|
||
| rt.spawn(async move { |
Member
There was a problem hiding this comment.
Suggested change
| rt.spawn(async move { | |
| rt.block_on(async move { |
otherwise current_rt() won't do anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
io_uring + symlinkat()