-
Notifications
You must be signed in to change notification settings - Fork 2
Implement native swift EHBP client instead of using gomobile #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 11 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="swift/Tests/EHBPTests/DeriveTests.swift">
<violation number="1" location="swift/Tests/EHBPTests/DeriveTests.swift:339">
P2: The `expectedKeyHex` value is parsed but never actually compared against the derived key. This makes the Go interoperability test incomplete - it only verifies `nonceBase` matches the Go implementation, not the key itself. Consider extracting the key bytes and comparing them, or at minimum remove the unused `expectedKeyHex` variable to avoid confusion.</violation>
</file>
<file name="swift/Tests/EHBPTests/SecurityTests.swift">
<violation number="1" location="swift/Tests/EHBPTests/SecurityTests.swift:33">
P2: The return value of `SecRandomCopyBytes` is discarded. If random number generation fails, the test would continue with zero-filled data, potentially giving false confidence in security properties. Consider checking the return value and failing the test on error.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
4c6957e to
1c1c029
Compare
|
@cubic-dev-ai review |
@sachaservan I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 17 files
1c1c029 to
f4f48c8
Compare
f9f78a5 to
5a01475
Compare
5a01475 to
671e296
Compare
Summary by cubic
Implemented a native Swift EHBP client and test suite, replacing gomobile bindings and updating CI and release workflows.
New Features
Refactors
Written for commit 671e296. Summary will update on new commits.