Refactor code for consistency and readability#246
Open
VitthalGupta wants to merge 2 commits intotimesler:masterfrom
Open
Refactor code for consistency and readability#246VitthalGupta wants to merge 2 commits intotimesler:masterfrom
VitthalGupta wants to merge 2 commits intotimesler:masterfrom
Conversation
- Updated string formatting to use double quotes consistently across the codebase. - Removed unnecessary blank lines and whitespace for cleaner code. - Improved print statements for clarity and consistency. - Refactored the `pass_epoch` function to enhance readability and maintainability. - Added a `pyproject.toml` file for package management, replacing the deprecated `setup.py`. - Removed the old `setup.py` file to streamline the project structure. - Updated test files to reflect consistent string formatting and improved readability. - Ensured compatibility with Python 3.10 and updated dependencies in `pyproject.toml`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on code style improvements and minor maintenance updates across the repository. The most significant change is the update to the supported Python version, along with consistent formatting and minor refactoring for clarity and maintainability.
Python version and compatibility:
.python-versionfile, signaling official support for Python 3.10.Code formatting and style improvements:
models/inception_resnet_v1.pyfor better readability and consistency. [1] [2] [3] [4] [5] [6] [7]models/inception_resnet_v1.py. [1] [2] [3] [4]__init__.py.Minor code maintenance:
models/mtcnn.pyfor consistency. [1] [2]Documentation:
README_cn.md, possibly as part of documentation cleanup or consolidation.These changes improve overall code quality, maintainability, and signal updated Python compatibility.- Updated string formatting to use double quotes consistently across the codebase.
pass_epochfunction to enhance readability and maintainability.pyproject.tomlfile for package management, replacing the deprecatedsetup.py.setup.pyfile to streamline the project structure.pyproject.toml.