refactor(ios): modernize kroll core with GCD#14395
Open
hansemannn wants to merge 8 commits intotidev:mainfrom
Open
refactor(ios): modernize kroll core with GCD#14395hansemannn wants to merge 8 commits intotidev:mainfrom
hansemannn wants to merge 8 commits intotidev:mainfrom
Conversation
Replace static recursive pthread_mutex_t with a serial dispatch queue using dispatch_queue_set_specific for re-entrancy detection. Fixes double-unlock bug in KrollEval invoke: and invokeWithResult: where pthread_mutex_unlock was called twice when an exception occurred. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…Invocation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace legacy locking primitives across 11 TitaniumKit source files: - TiProxy: pthread_rwlock_t → concurrent dispatch queues with barriers for listener and dynprops access; OSAtomic → stdatomic for bridgeCount - TiViewProxy: pthread_rwlock_t → concurrent dispatch queue for children; NSRecursiveLock → serial dispatch queue with re-entrancy for destroy - ObjcProxy: pthread_rwlock_t → concurrent dispatch queue for listeners - KrollCallback: NSLock → serial dispatch queue for callback registry - ImageLoader: NSRecursiveLock → serial dispatch queue - TiLayoutQueue: pthread_mutex_t → serial dispatch queue - TiUIWindowProxy: NSCondition → dispatch_semaphore_t + serial queue Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Anything particular to test or is it more a: check if apps still work like before and don't crash? same app with 13.1.1 works fine. |
Collaborator
Author
|
Thanks! It still requires more testing, this one is AI powered on purpose - let's see how it works out :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request modernizes and improves thread safety and timer management throughout the TitaniumKit code base. The main changes replace legacy locking and timer APIs with more efficient and safer alternatives, update the timer manager to use GCD-based timers for better performance and accuracy, and refactor singleton and static initialization patterns for thread safety.
These changes collectively improve the reliability, safety, and maintainability of the TitaniumKit core, especially in multithreaded and timer-heavy scenarios. It is a follow-up of #14260 with a more detailed implementation plan for possible iterations. It also catches way more scenarios.
Note: This will not make apps 10x faster out of a sudden, but primarily improves debugging capabilities (with clear labels where which GCD ran). It still slightly improves app launch or opening more complex windows, where many TiProxy instances are created.