ShellPkg/UefiShellLevel3: Code cleanup/refactor#12513
Merged
mergify[bot] merged 8 commits intotianocore:masterfrom May 1, 2026
Merged
ShellPkg/UefiShellLevel3: Code cleanup/refactor#12513mergify[bot] merged 8 commits intotianocore:masterfrom
mergify[bot] merged 8 commits intotianocore:masterfrom
Conversation
tianocore-assign-reviewers
Bot
requested review from
ajfish,
ardbiesheuvel,
leiflindholm,
makubacki and
mdkinney
3 tasks
pierregondois
force-pushed
the
pg/ShellPkgLevel3
branch
2 times, most recently
from
d41a22c to
21600ca
Compare
leiflindholm
approved these changes
Apr 30, 2026
|
Deprecation notice: This pull request comes from a fork and was queued with |
Merge Queue Status
This pull request spent 32 minutes 30 seconds in the queue, including 31 minutes 53 seconds running CI. Required conditions to merge
|
Signed-off-by: Pierre Gondois <[email protected]>
Signed-off-by: Pierre Gondois <[email protected]>
Signed-off-by: Pierre Gondois <[email protected]>
This patch aims to help breaking down the long function present in the ShellPkg and reduce complexity/nested code and conditions. Return directly if ShellCommandLineParse() returned an error Status. In such case, the "Package" that should be allocated by ShellCommandLineParse() is already freed in: ShellCommandLineParse() \-ShellCommandLineParseEx() \-InternalCommandLineParse() so there is no need to free it with ShellCommandLineFreeVarList(). No functional change should be induced by this patch. Signed-off-by: Pierre Gondois <[email protected]>
This patch aims to help breaking down the long function present in the ShellPkg and reduce complexity/nested code and conditions. Extract a MainCmdXXX() function for each shell command. This command contains the possible operations the command aims to operate. The ShellCommandRunXXX() function from which it is extracted is only responsible of: - initializing the shell/command environment - parsing the command parameter and creating a Package - freeing the Package No functional change should be induced by this patch. Signed-off-by: Pierre Gondois <[email protected]>
Extract a ProcessFileList() in: - Touch.c - Type.c to lower the indentation level and simplify the logic. No functional change should be induced by this patch. Signed-off-by: Pierre Gondois <[email protected]>
Extract a PrintMatchingHelp() function in the Help command to help splitting the logic MainCmdHelp() function. No functional change should be induced by this patch. Signed-off-by: Pierre Gondois <[email protected]>
This patch aims to help breaking down the long function present in the ShellPkg and reduce complexity/nested code and conditions. Lower the indentation level in the newly created MainCmdXXX() functions. Some ASSERT() are removed in Help.c as they check variables which were initialized a few lines above. No functional change should be induced by this patch. Signed-off-by: Pierre Gondois <[email protected]>
tianocore-issues
force-pushed
the
pg/ShellPkgLevel3
branch
from
21600ca to
24b6abd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small cleanup/refactor of the UefiShellLevel3 commands.
No functional change should be induced by these patches.