MdeModulePkg/DxeCapsuleLibFmp: Tolerate EFI_ALREADY_STARTED in LockVariable#12511
Merged
mergify[bot] merged 1 commit intotianocore:masterfrom Apr 30, 2026
Merged
Conversation
anandhkrishnau
force-pushed
the
Anandh/FixCapsuleLib
branch
from
edf3fe8 to
006050b
Compare
lgao4
approved these changes
Apr 30, 2026
|
Deprecation notice: This pull request comes from a fork and was queued with |
Merge Queue Status
This pull request spent 20 minutes 46 seconds in the queue, including 20 minutes 21 seconds running CI. Required conditions to merge
|
…riable When multiple DXE drivers link DxeCapsuleLib, each driver's constructor calls InitCapsuleVariable() which attempts to lock capsule-related variables. The second instance fails with EFI_ALREADY_STARTED because the policy is already registered, triggering a false ASSERT. EFI_ALREADY_STARTED from RegisterBasicVariablePolicy means the variable is already locked, which is the desired state. Treat it as success. Signed-off-by: default avatarAnandh krishna U <[email protected]>
tianocore-issues
force-pushed
the
Anandh/FixCapsuleLib
branch
from
006050b to
4eb7395
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple DXE drivers link DxeCapsuleLib, each driver's constructor calls InitCapsuleVariable() which attempts to lock capsule-related variables. The second instance fails with EFI_ALREADY_STARTED because the policy is already registered, triggering a false ASSERT.
EFI_ALREADY_STARTED from RegisterBasicVariablePolicy means the variable is already locked, which is the desired state. Treat it as success.
How This Was Tested
Tested with including the DxeCapsuleLib with multiple DXE drivers
Integration Instructions
N/A