ShellPkg/AcpiView: Update MPAM table "MMIO size" field check#12480
Merged
mergify[bot] merged 1 commit intotianocore:masterfrom Apr 20, 2026
Merged
ShellPkg/AcpiView: Update MPAM table "MMIO size" field check#12480mergify[bot] merged 1 commit intotianocore:masterfrom
mergify[bot] merged 1 commit intotianocore:masterfrom
Conversation
The "ACPI for Memory System Resource Partitioning and Monitoring" spec (Arm DEN0065, [1]) in version 2.0 described the "MMIO size" field in the "MPAM MSC node" subtable as being always 0 if the the "PCC" interface type is used for that MSC. Version 3.0 of the spec changes that field to convey the enablement status of that MSC: "If set to 1, this MSC is accessible ... If set to 0, this MSC is non-functional...." Relax the strict check for this value being 0 in the acpiview validation checks, to also allow the new value of "1". [1] https://developer.arm.com/documentation/den0065/3-0/ Signed-off-by: Andre Przywara <andre.przywara@arm.com>
tianocore-assign-reviewers
bot
requested review from
ajfish,
ardbiesheuvel,
leiflindholm,
makubacki,
mdkinney and
pierregondois
samimujawar
approved these changes
Apr 18, 2026
pierregondois
approved these changes
Apr 20, 2026
ardbiesheuvel
approved these changes
Apr 20, 2026
Merge Queue Status
This pull request spent 12 seconds in the queue, including 1 second running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "ACPI for Memory System Resource Partitioning and Monitoring" spec (Arm DEN0065, [1]) in version 2.0 described the "MMIO size" field in the "MPAM MSC node" subtable as being always 0 if the the "PCC" interface type is used for that MSC. Version 3.0 of the spec changes that field to convey the enablement status of that MSC: "If set to 1, this MSC is accessible ... If set to 0, this MSC is non-functional...."
Relax the strict check for this value being 0 in the acpiview validation checks, to also allow the new value of "1".
[1] https://developer.arm.com/documentation/den0065/3-0/
How This Was Tested
Adding an MPAM ACPI table describing one MSC as using the MPAM-Fb interface type. Then running "acpiview" to validate the table. Tested on the kvmtool port.
Integration Instructions
N/A