UefiCpuPkg/BaseRiscVMmuLib: Support MMU page unmap#12393
Open
benjamindoron wants to merge 2 commits intotianocore:masterfrom
Open
UefiCpuPkg/BaseRiscVMmuLib: Support MMU page unmap#12393benjamindoron wants to merge 2 commits intotianocore:masterfrom
benjamindoron wants to merge 2 commits intotianocore:masterfrom
Conversation
benjamindoron
force-pushed
the
upstream/riscv-mmu-leaf-fix
branch
from
9573f01 to
1d967df
Compare
tianocore-assign-reviewers
Bot
requested review from
LiuZhiguang001,
arunsbaskaran,
ecuevasf,
jiaxinwu,
kraxel,
lzeng14,
niruiyu and
td36
3 tasks
Entries with the 'valid' bit set and RWX bits cleared are considered "table entries" (non-leaves). With the page table in this state, future map operations will trigger assertions when they reach the final level, and encounter what looks like a valid non-leaf entry. Signed-off-by: Benjamin Doron <[email protected]>
benjamindoron
force-pushed
the
upstream/riscv-mmu-leaf-fix
branch
from
1d967df to
fe7aafc
Compare
Add support for the EFI_MEMORY_RP GCD attribute, completing the support for the standardised page attributes and thereby allowing common code to unmap pages. This fixes potential security vulnerabilities, as out of bounds memory accesses can now be caught by the MMU. Signed-off-by: Benjamin Doron <[email protected]>
github-actions
Bot
added
the
impact:security
benjamindoron
changed the title
Contributor
|
Thanks for the patch. LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for the EFI_MEMORY_RP GCD attribute, completing the support
for the standardised page attributes and thereby allowing common code to
unmap pages.
This fixes potential security vulnerabilities, as out of bounds memory
accesses can now be caught by the MMU.
How This Was Tested
This was tested as part of #12314
Integration Instructions
N/A