feat(notifications): show avatars on message notifications#9652
Merged
rafaeltonholo merged 1 commit intothunderbird:mainfrom Jan 15, 2026
Merged
feat(notifications): show avatars on message notifications#9652rafaeltonholo merged 1 commit intothunderbird:mainfrom
rafaeltonholo merged 1 commit intothunderbird:mainfrom
Conversation
Goooler
commented
Aug 26, 2025
legacy/core/src/main/java/com/fsck/k9/notification/SingleMessageNotificationCreator.kt
Show resolved
Hide resolved
Contributor
|
Thanks for working on this! We're going to run this by design before reviewing but then we'll get back to it |
Contributor
|
At the moment we are not planning to increase the min sdk version as we continue to support as many versions of android as we can. That being said, if you want to add code to support the behavior on SDK23 and above, that would be ok. This looks snazzy if you do end up doing that! |
Goooler
force-pushed
the
message-noti-avatar
branch
from
c6811ba to
2e4a197
Compare
Contributor
Author
|
Done! |
Goooler
force-pushed
the
message-noti-avatar
branch
from
2e4a197 to
cc05484
Compare
wmontwe
force-pushed
the
message-noti-avatar
branch
from
cc05484 to
f798766
Compare
Member
|
@rafaeltonholo, @Goooler I updated the PR, works as expected. Sorry for the long wait. |
wmontwe
changed the title
rafaeltonholo
previously approved these changes
Jan 14, 2026
Member
rafaeltonholo
left a comment
rafaeltonholo
left a comment
There was a problem hiding this comment.
LGTM, just left a minor comment
legacy/core/src/main/java/com/fsck/k9/notification/CoreNotificationKoinModule.kt
Outdated
Show resolved
Hide resolved
Goooler
force-pushed
the
message-noti-avatar
branch
from
f798766 to
1c037e5
Compare
rafaeltonholo
temporarily deployed
to
botmobile
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7089.