Skip to content

feat(thundermail): onboard thundermail into the app#10985

Merged
rafaeltonholo merged 21 commits intomainfrom
feature/thundermail-mvp
May 5, 2026
Merged

feat(thundermail): onboard thundermail into the app#10985
rafaeltonholo merged 21 commits intomainfrom
feature/thundermail-mvp

Conversation

@rafaeltonholo
Copy link
Copy Markdown
Member

@rafaeltonholo rafaeltonholo commented May 5, 2026

Resolves #10984.
feature-flag: thundermail_onboarding_enabled

This pull request integrates the new Thundermail feature modules and associated feature flags into both the K-9 Mail and Thunderbird Android applications. It ensures the Thundermail onboarding flow is available and configurable via feature flags across all app variants (debug, beta, release, and daily). Additionally, it updates dependency injection and test configurations to support the new modules.

Thundermail Feature Integration:

  • Added Thundermail feature modules (feature.thundermail.api, feature.thundermail.k9mail, feature.thundermail.thunderbird, and feature.thundermail.internal.common) to the dependencies of K-9 Mail and Thunderbird apps, including both implementation and test scopes.
  • Updated dependency injection modules to include the new Thundermail modules (featureThundermailModule, featureThundermailCommonModule) in both K-9 Mail and Thunderbird app modules.

Feature Flag Management:

  • Registered the new ThundermailOnboardingEnabled feature flag in all app variants (debug, beta, release, and daily) for both K-9 Mail and Thunderbird. The flag's default value varies by variant (enabled for debug/daily, disabled for release/beta).

Testing and Dependency Injection:

  • Added Thundermail contract ViewModel definitions to dependency injection test configurations for both K-9 Mail and Thunderbird to ensure proper wiring and test coverage.

…en converting from and to Material3 ButtonColors

fix(design-system): outlined border ignoring enabled parameter
… flow

Move QR code scanning from account setup to dedicated Thundermail navigation module. Register Thundermail routes in FeatureLauncherNavHost and handle navigation between QR code scanning and account setup completion.
…reen

Add separate callbacks for Thundermail sign-in and QR code scanning. Update ThundermailButtonPanel to handle both actions independently and reduce visibility of route constants to internal.
@rafaeltonholo rafaeltonholo requested a review from a team as a code owner May 5, 2026 16:47
@rafaeltonholo rafaeltonholo requested a review from jbott-tbird May 5, 2026 16:47
@github-actions github-actions Bot added the tb-team Tasks and features handled by project maintainers label May 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Validation Passed: All report and feature-flag labels are correctly set.

@rafaeltonholo rafaeltonholo added the report: highlight Highlight changes (major feature, breaking, or noticeable to users) in user-facing reports. label May 5, 2026
@rafaeltonholo rafaeltonholo added the feature-flag Changes guarded by a feature flag. Please add a comment stating the name: "feature-flag: abc" label May 5, 2026
Copy link
Copy Markdown
Contributor

@dani-zilla dani-zilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be the same as the commits that make it up. Ran a quick smoke test locally, was able to set up accounts with the QR code as expected.

@rafaeltonholo rafaeltonholo merged commit 13d7a9b into main May 5, 2026
19 of 22 checks passed
@rafaeltonholo rafaeltonholo deleted the feature/thundermail-mvp branch May 5, 2026 17:50
@thunderbird-botmobile thunderbird-botmobile Bot added this to the Thunderbird 20 milestone May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-flag Changes guarded by a feature flag. Please add a comment stating the name: "feature-flag: abc" report: highlight Highlight changes (major feature, breaking, or noticeable to users) in user-facing reports. tb-team Tasks and features handled by project maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Thundermail Integration - Phase 1 - MVP

3 participants