feat(thundermail): onboard thundermail into the app#10985
Merged
rafaeltonholo merged 21 commits intomainfrom May 5, 2026
Merged
feat(thundermail): onboard thundermail into the app#10985rafaeltonholo merged 21 commits intomainfrom
rafaeltonholo merged 21 commits intomainfrom
Conversation
…en converting from and to Material3 ButtonColors fix(design-system): outlined border ignoring enabled parameter
…ermail and Scan QR code
… flow Move QR code scanning from account setup to dedicated Thundermail navigation module. Register Thundermail routes in FeatureLauncherNavHost and handle navigation between QR code scanning and account setup completion.
…reen Add separate callbacks for Thundermail sign-in and QR code scanning. Update ThundermailButtonPanel to handle both actions independently and reduce visibility of route constants to internal.
…or better visual balance on smaller screens
…ing with dependency injection
Contributor
|
✅ Validation Passed: All report and feature-flag labels are correctly set. |
dani-zilla
approved these changes
May 5, 2026
Contributor
dani-zilla
left a comment
There was a problem hiding this comment.
Seems to be the same as the commits that make it up. Ran a quick smoke test locally, was able to set up accounts with the QR code as expected.
coreycb
pushed a commit
that referenced
this pull request
May 8, 2026
coreycb
added a commit
that referenced
this pull request
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #10984.
feature-flag:
thundermail_onboarding_enabledThis pull request integrates the new Thundermail feature modules and associated feature flags into both the K-9 Mail and Thunderbird Android applications. It ensures the Thundermail onboarding flow is available and configurable via feature flags across all app variants (debug, beta, release, and daily). Additionally, it updates dependency injection and test configurations to support the new modules.
Thundermail Feature Integration:
feature.thundermail.api,feature.thundermail.k9mail,feature.thundermail.thunderbird, andfeature.thundermail.internal.common) to the dependencies of K-9 Mail and Thunderbird apps, including both implementation and test scopes.featureThundermailModule,featureThundermailCommonModule) in both K-9 Mail and Thunderbird app modules.Feature Flag Management:
ThundermailOnboardingEnabledfeature flag in all app variants (debug, beta, release, and daily) for both K-9 Mail and Thunderbird. The flag's default value varies by variant (enabled for debug/daily, disabled for release/beta).Testing and Dependency Injection: