Skip to content

feat(thundermail-mvp): set the thundermail feature foundation#10969

Merged
rafaeltonholo merged 10 commits intothunderbird:feature/thundermail-mvpfrom
rafaeltonholo:feat/thundermail-mvp-foundation
May 4, 2026
Merged

feat(thundermail-mvp): set the thundermail feature foundation#10969
rafaeltonholo merged 10 commits intothunderbird:feature/thundermail-mvpfrom
rafaeltonholo:feat/thundermail-mvp-foundation

Conversation

@rafaeltonholo
Copy link
Copy Markdown
Member

This pull request includes the changes already present on feature/thundermail, but targeting the MVP instead of the full feature.

From #10913:

  • Add contentPadding parameter to ButtonOutlined
  • Add leading icon to button filled
  • Add customizable colours and shapes to design system buttons

From #10914:

  • Add stroke support to iconPath in IconBuilder
  • Add FilledThundermail icon to design system
  • Add qr-code icon

From #10915:

  • Add the scaffold project for the Thundermail feature
  • Wire the Thundermail :k9app and :thunderbird dedicated implementation with their respective apps.

From #10931:

  • Migrate Thundermail modules to full Android modules to avoid unnecessary workarounds, as part of our design system is not yet kmp

@rafaeltonholo rafaeltonholo requested a review from a team as a code owner May 1, 2026 13:11
@rafaeltonholo rafaeltonholo requested review from jbott-tbird and removed request for a team May 1, 2026 13:11
@rafaeltonholo rafaeltonholo added the feature-flag Changes guarded by a feature flag. Please add a comment stating the name: "feature-flag: abc" label May 1, 2026
@github-actions github-actions Bot added the tb-team Tasks and features handled by project maintainers label May 1, 2026
@rafaeltonholo rafaeltonholo added report: exclude Exclude changes from user-facing reports (internal, minor, or not relevant to users). and removed tb-team Tasks and features handled by project maintainers feature-flag Changes guarded by a feature flag. Please add a comment stating the name: "feature-flag: abc" labels May 1, 2026
@wmontwe wmontwe requested review from wmontwe and removed request for jbott-tbird May 4, 2026 07:42
@wmontwe wmontwe assigned wmontwe and unassigned jbott-tbird May 4, 2026
Copy link
Copy Markdown
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we could patch the design later once clarified.

import net.thunderbird.core.ui.compose.designsystem.atom.icon.icon
import net.thunderbird.core.ui.compose.designsystem.atom.icon.iconPath

internal val OutlinedQrCode: ImageVector by lazy {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that some of the spacing and sizing values don’t align with the Android 4dp grid (e.g. the 18dp icons). It looks like parts of the design might be based on a 3px desktop grid.

I’ve reached out to design to verify whether this was intentional. The 18dp icons stand out compared to our standard 24dp icons and are also not cleanly dividable by 4.

…en converting from and to Material3 ButtonColors

fix(design-system): outlined border ignoring enabled parameter
@rafaeltonholo
Copy link
Copy Markdown
Member Author

Thanks for the review, @wmontwe! I've updated the ButtonFilled API to match with the ButtonOutlined. I also fixed a bug on ButtonOutlined, which, when it was disabled, the border was not updating its colour, and the text was transparent.

Copy link
Copy Markdown
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaeltonholo rafaeltonholo merged commit 6a66fbc into thunderbird:feature/thundermail-mvp May 4, 2026
14 checks passed
@rafaeltonholo rafaeltonholo deleted the feat/thundermail-mvp-foundation branch May 4, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

report: exclude Exclude changes from user-facing reports (internal, minor, or not relevant to users).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants