feat(thundermail-mvp): set the thundermail feature foundation#10969
Merged
rafaeltonholo merged 10 commits intothunderbird:feature/thundermail-mvpfrom May 4, 2026
Merged
Conversation
wmontwe
approved these changes
May 4, 2026
Member
wmontwe
left a comment
There was a problem hiding this comment.
LGTM, I think we could patch the design later once clarified.
| import net.thunderbird.core.ui.compose.designsystem.atom.icon.icon | ||
| import net.thunderbird.core.ui.compose.designsystem.atom.icon.iconPath | ||
|
|
||
| internal val OutlinedQrCode: ImageVector by lazy { |
Member
There was a problem hiding this comment.
I noticed that some of the spacing and sizing values don’t align with the Android 4dp grid (e.g. the 18dp icons). It looks like parts of the design might be based on a 3px desktop grid.
I’ve reached out to design to verify whether this was intentional. The 18dp icons stand out compared to our standard 24dp icons and are also not cleanly dividable by 4.
…en converting from and to Material3 ButtonColors fix(design-system): outlined border ignoring enabled parameter
Member
Author
|
Thanks for the review, @wmontwe! I've updated the |
6a66fbc
into
thunderbird:feature/thundermail-mvp
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes the changes already present on feature/thundermail, but targeting the MVP instead of the full feature.
From #10913:
contentPaddingparameter toButtonOutlinedFrom #10914:
From #10915:
From #10931: