Skip to content

feat(ui): Added header and margin for print Emails#10932

Open
saisafe wants to merge 3 commits intothunderbird:mainfrom
saisafe:print-header-margin
Open

feat(ui): Added header and margin for print Emails#10932
saisafe wants to merge 3 commits intothunderbird:mainfrom
saisafe:print-header-margin

Conversation

@saisafe
Copy link
Copy Markdown

@saisafe saisafe commented Apr 21, 2026 •
edited
Loading

Summary

Solves #10567
Wrap content in a structured HTML document

PDF Outputs (Final)

a_redacted.pdf
2_redacted.pdf

Pending tasks:

  • Adding Email-ID of sender
  • Removing Hyperlinks

@saisafe saisafe requested a review from a team as a code owner April 21, 2026 18:43
@saisafe saisafe requested a review from rafaeltonholo April 21, 2026 18:43
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

Missing report label. Set exactly one of: report: include, report: exclude OR report: highlight.

@wmontwe wmontwe added the report: include Include changes in user-facing reports. label Apr 22, 2026
saisafe added 2 commits April 22, 2026 18:41
@saisafe
feat(ui): Regex method to remove hyperlinks.
f1ef705 
This worked well stripping Hyperlinks and buttons under <a> HTML tag. I tested this on my Google Activity mail and worked well.
@saisafe
feat(ui): Added sender Email-ID and final null checks
446c5b7 
Added "<" ">" checks to subject.
Replaced <$email> in `from:`
Replaced <p> to .page-wrapper with checks
@saisafe
Copy link
Copy Markdown
Author

saisafe commented Apr 22, 2026

@rafaeltonholo I've tried to make this print Email similar to thunderbird-desktop. Kindly let me know if any changes needed.

@wmontwe
Copy link
Copy Markdown
Member

wmontwe commented Apr 24, 2026

@saisafe Thanks for your contribution. Could you please run ./gradlew spotlessApply and ./gradlew detekt to check for code style and code issues.

@wmontwe wmontwe requested review from wmontwe and removed request for rafaeltonholo April 24, 2026 07:36
@wmontwe wmontwe assigned wmontwe and unassigned rafaeltonholo Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmontwe wmontwe Awaiting requested review from wmontwe

At least 1 approving review is required to merge this pull request.

Assignees

@wmontwe wmontwe

Labels

report: include Include changes in user-facing reports.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saisafe @wmontwe @rafaeltonholo