refactor: convert Attachment class to Kotlin#10482
Open
mohitsatr wants to merge 2 commits intothunderbird:mainfrom
Open
refactor: convert Attachment class to Kotlin#10482mohitsatr wants to merge 2 commits intothunderbird:mainfrom
mohitsatr wants to merge 2 commits intothunderbird:mainfrom
Conversation
Author
|
I just noticed PR's title format should be like that of the commit - |
Goooler
reviewed
Feb 6, 2026
| */ | ||
| @Suppress("LongParameterList") | ||
| class Attachment( | ||
| val uri: Uri, |
Contributor
There was a problem hiding this comment.
Suggested change
| val uri: Uri, | |
| @JvmField | |
| val uri: Uri, |
You can mark these properties as @JvmField to get rid of attachment.getUri() changes in Java code.
Author
There was a problem hiding this comment.
Done for uri, loaderId, and allowMessageType. @JvmField only works for non overriden property.
I think it's not an issue. I will convert these other java files into kotlin after this one
mohitsatr
force-pushed
the
attachment-to-kt
branch
from
50657a5 to
b4d8961
Compare
wmontwe
changed the title
wmontwe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #9277
Related changes:
MessageCompose.java,AttachmentPresenter.java,AttachmentInfoLoader.java, andAttachmentContentLoader.java