Skip to content

Multiple AUTH_HOST support#302

Open
adyanth wants to merge 4 commits intothomseddon:masterfrom
adyanth:115-auth-host
Open

Multiple AUTH_HOST support#302
adyanth wants to merge 4 commits intothomseddon:masterfrom
adyanth:115-auth-host

Conversation

@adyanth
Copy link
Copy Markdown

@adyanth adyanth commented Feb 18, 2022

Allows support for using multiple AUTH_HOSTs
Fixes #115

@adyanth
Copy link
Copy Markdown
Author

adyanth commented Feb 18, 2022

Hey @thomseddon if you can confirm if this approach works, I can add a couple more test cases for the multi AUTH_HOST scenario.

@adyanth adyanth changed the title WIP: Multiple AUTH_HOST support Multiple AUTH_HOST support Mar 12, 2022
@adyanth
Copy link
Copy Markdown
Author

adyanth commented Mar 17, 2022

Can confirm this works, using it in my own setup with k3s + Traefik.

@com6056
Copy link
Copy Markdown

com6056 commented Jun 2, 2022

@thomseddon any updates on getting this reviewed and merged in?

@TBG-FR
Copy link
Copy Markdown

TBG-FR commented Oct 27, 2023

Great PR !

@ItalyPaleAle
Copy link
Copy Markdown

Thanks for this PR! I've been using it for many months in a fork: https://github.com/italypaleale/traefik-forward-auth (Also publishing multi-arch Docker images)

@maxexcloo
Copy link
Copy Markdown

Thanks for this PR! I've been using it for many months in a fork: https://github.com/italypaleale/traefik-forward-auth (Also publishing multi-arch Docker images)

Not sure the best place to contact you but I was wondering if you plan on adding back features such as allowed domains? I really like your fork and that's all that's missing for me at the moment :)

@ItalyPaleAle
Copy link
Copy Markdown

Thanks for this PR! I've been using it for many months in a fork: https://github.com/italypaleale/traefik-forward-auth (Also publishing multi-arch Docker images)

Not sure the best place to contact you but I was wondering if you plan on adding back features such as allowed domains? I really like your fork and that's all that's missing for me at the moment :)

Version 2 still has them! I recently updated to v3 which was a complete rewrite and changed a lot of things. Feel free to open issues and PRs :)

@maxexcloo
Copy link
Copy Markdown

Version 2 still has them! I recently updated to v3 which was a complete rewrite and changed a lot of things. Feel free to open issues and PRs :)

Issues seem to be disabled, mind enabling? I'll move this discussion there and maybe try to put in a PR (although I'm new to Go!)

@ItalyPaleAle
Copy link
Copy Markdown

Version 2 still has them! I recently updated to v3 which was a complete rewrite and changed a lot of things. Feel free to open issues and PRs :)

Issues seem to be disabled, mind enabling? I'll move this discussion there and maybe try to put in a PR (although I'm new to Go!)

Done, I didn't realize they were disabled sorry

@ItalyPaleAle
Copy link
Copy Markdown

Thanks for this PR! I've been using it for many months in a fork: https://github.com/italypaleale/traefik-forward-auth (Also publishing multi-arch Docker images)

Not sure the best place to contact you but I was wondering if you plan on adding back features such as allowed domains? I really like your fork and that's all that's missing for me at the moment :)

@maxexcloo Support for allowlists (including domains for Google), has been re-added in 3.1.0: https://github.com/ItalyPaleAle/traefik-forward-auth/releases/tag/v3.1.0

@maxexcloo
Copy link
Copy Markdown

Thanks for this PR! I've been using it for many months in a fork: https://github.com/italypaleale/traefik-forward-auth (Also publishing multi-arch Docker images)

Not sure the best place to contact you but I was wondering if you plan on adding back features such as allowed domains? I really like your fork and that's all that's missing for me at the moment :)

@maxexcloo Support for allowlists (including domains for Google), has been re-added in 3.1.0: https://github.com/ItalyPaleAle/traefik-forward-auth/releases/tag/v3.1.0

That’s absolutely amazing man! I haven’t been at my PC this weekend but I’ll be sure to give it a test tomorrow 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Support multiple auth-host's

5 participants