Implement facet_wrap_paginate() wrapper and n_pages() fix#91
Open
broomej wants to merge 9 commits intothomasp85:mainfrom
Open
Implement facet_wrap_paginate() wrapper and n_pages() fix#91broomej wants to merge 9 commits intothomasp85:mainfrom
broomej wants to merge 9 commits intothomasp85:mainfrom
Conversation
Add a convenient wrapper which calculates the number of pages necessary for facet_wrap_paginate and generates all of the pages. Documentation not roxygenized yet.
Fix as suggested by @guiastrennec in issue thomasp85#84
ggforce wasn't passing devtools::check because ggplot2::scale_type() wasn't exported until v2.2.1.9000
broomej
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #81 and #84.
gen_all_pages_fwp()returns a list where each element is a page generated byfacet_wrap_paginate(). It relies onn_pages(), so I included the fix suggested by @guiastrennec. Additionally, the package wasn't passingdevtools::check()because of a feature added which relies onggplot2::scale_type(), which wasn't available until ggplot2 v2.2.1.9000, so I increased the version dependency in DESCRIPTION