flexible buffer length checking#4
Open
mfrederickson wants to merge 9 commits intothirtysixthspan:masterfrom
Open
flexible buffer length checking#4mfrederickson wants to merge 9 commits intothirtysixthspan:masterfrom
mfrederickson wants to merge 9 commits intothirtysixthspan:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work around for #3. You can have the buffer length check turned off by passing in
required_buffer_length: 0to the read method like this (otherwise it defaults to 337):This commit also includes changing from an explicit interrupt_transfer call to using the interrupt_transfer call on the device handle so that we don't have to worry with buffer management.