PSR-14 Event Dispatcher#1184
Open
eugene-borovov wants to merge 10 commits intothephpleague:masterfrom
Open
Conversation
derrabus
suggested changes
Mar 3, 2021
Contributor
derrabus
left a comment
derrabus
left a comment
There was a problem hiding this comment.
Thank you for working on this. Switching to PSR-14 would certainly help with integrating this library into frameworks that already provide a PSR-14 event dispatcher.
Signed-off-by: Eugene Borovov <eugene.borovov@gmail.com>
Signed-off-by: Eugene Borovov <eugene.borovov@gmail.com>
Signed-off-by: Eugene Borovov <eugene.borovov@gmail.com>
Signed-off-by: Eugene Borovov <eugene.borovov@gmail.com>
Signed-off-by: Eugene Borovov <eugene.borovov@gmail.com>
Signed-off-by: Eugene Borovov <eugene.borovov@gmail.com>
Signed-off-by: Eugene Borovov <eugene.borovov@gmail.com>
Signed-off-by: Eugene Borovov <eugene.borovov@gmail.com>
Signed-off-by: Eugene Borovov <eugene.borovov@gmail.com>
eugene-borovov
force-pushed
the
psr-event-dispatcher
branch
from
9122091 to
27ff32f
Compare
|
What's the hold-up on this PR and PSR-14? I'm using the |
|
@Sephster is there any chance to get this merged ? It would make things a lot easier for frameworks (for instance, symfony/event-dispatcher implements the PSR-14 interface so the bundle could drop its current adapter layer forwarding events to the Symfony EventDispatcher) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR inspired of #1168 and #1145.