add PSR15/PSR-17 compliant middleware#1029
add PSR15/PSR-17 compliant middleware#1029datapp wants to merge 9 commits intothephpleague:masterfrom
Conversation
|
Apologies for the delay on looking at this @datapp. I'm planning on merging this in later today although I will likely move the middleware into its own PSR folder instead of including PSR in the name. Many thanks for your efforts with this! |
|
This branch has not been merged yet. Could you merge it please @Sephster ? |
|
Sorry I completely forgot about this. I'm focusing on the Device Auth Grant at the moment but will pick this up as soon as I can. |
|
bump :-) |
|
bump, please - this looks good 👍 |
|
any updates on this? |
eugene-borovov
left a comment
eugene-borovov
left a comment
There was a problem hiding this comment.
The Authorization Server Middleware doesn`t work :-(
| public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface | ||
| { | ||
| try { | ||
| $response = $this->server->respondToAccessTokenRequest($request, $this->responseFactory->createResponse()); |
There was a problem hiding this comment.
You should return the response here
| } | ||
|
|
||
| // Pass the request on to the next responder in the chain | ||
| return $handler->handle($request); |
There was a problem hiding this comment.
This statement is unreachable.
| $requestHandlerMock | ||
| ); | ||
|
|
||
| $this->assertEquals(200, $response->getStatusCode()); |
There was a problem hiding this comment.
Add tests for the body of the response. Now it is empty.
|
@Sephster any change you may (correct if and) merge this these days? |
|
The auth server middleware actually makes no sense, you should only have your auth and access token end points, where else would we want that? |
|
@delboy1978uk would just be nice to include |
8 participants
resolves issue #942