Add certs command #935
Draft
Add certs command #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 26, 2025
evgeni
reviewed
Mar 5, 2025
evgeni
reviewed
Mar 5, 2025
ehelms
force-pushed
the
certs-command
branch
3 times, most recently
from
cd4e29a to
29d2d21
Compare
Member
Author
Member
Author
|
This requires theforeman/puppet-certs#449 and will remain in draft until it's merged. |
ehelms
force-pushed
the
certs-command
branch
2 times, most recently
from
1609d58 to
feec588
Compare
evgeni
force-pushed
the
certs-command
branch
2 times, most recently
from
c0e12a9 to
05a0bb3
Compare
Member
|
/packit build |
evgeni
force-pushed
the
certs-command
branch
from
ed4f09d to
4c5f2bc
Compare
ehelms
force-pushed
the
certs-command
branch
from
4c5f2bc to
6b050e5
Compare
evgeni
force-pushed
the
certs-command
branch
2 times, most recently
from
271e39c to
d49b954
Compare
Signed-off-by: Eric D. Helms <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to introduce a command that can stand-alone generate certificates as is done within the installer using the same logic of puppet-certs module. This intentionally does not cover deployment, it simply allows generation of the certificates. This relies upon theforeman/puppet-certs#449 as it introduces a class that makes this process works and avoids the complication that the individual certificate classes create via their params.
The full design idea is to split generation from deployment and allow generation to happen prior to full
puppet applywithin the installer and allow the installer part to only handle deployment. This will put us a step closer to allowing users to provider their own certificates by standardizing on the set of certificates as inputs where those inputs can come directly from the user or from the self-generated set.