Make overblog/graphiql-bundle optional#272
Make overblog/graphiql-bundle optional#272andrew-demb merged 1 commit intothecodingmachine:masterfrom
Conversation
|
Is it necessary to drop GraphiQL-related classes from the DI container in case of a non-existing dependency? |
Good point. Currently, the compiler pass does not reference any Overblog GraphiQL classes directly, so declaring the service alone should not crash even if the bundle is not installed. That said, now that overblog/graphiql-bundle is optional, it would probably be safer to guard this wiring (e.g. checking bundle presence or class existence) to avoid registering GraphiQL-related services when the dependency is not installed. I didn’t include this change in the PR since the goal here was limited to making the dependency optional at the Composer level. |
|
OK, let's merge as is. Thank you @charly-ffss |
Fixes #271
Refs #245
This makes overblog/graphiql-bundle truly optional, as documented.
It allows installing graphqlite-bundle on Symfony 8 without requiring GraphiQL.