Local improvements#33
Conversation
* LED update is based on the currentMode variable, not the Mode variable. On initial startup getConfig sets Mode, but currentMode is left unset. As this isn't a valid mode the refresh loop sets both values to the default Colour, requiring the config be rerear. FIX: Set currentMode when initializing the LEDs. * More complex modes make the LEDs flicker; instead of running the render code every update add a toggle to alternate between render or show giving other code a chance to run between slow renders and strip refresh. Most likely being caused by wifi processing/buffering and this fixes it on my devices.
|
Looks like Lars also implemented a different fix to both the currentMode and led flicker issues. The Name and VSCode changes are still useful and I can rebase this without the two bug fixes instead. I'm not sure if his change for the flicker is sufficient though - I tried a similar approach and while reduced I still had flickering. For me it was sufficient to do a loop between the render and draw code to give the rest of the code a chance to process other events. I'm running two ESP8266s, one with 100 LEDs and one with ~80 LEDs (but set to 100 in the build still). Both exhibited this issue. |
|
3605f1d - I like the idea of adding platform IO. I have no experience in it though, so are all the files committed required or do you just need the config file? ed08f37 - I believe this has been fixed? I have lost the commit to where it is however. I'll have to double check. 1cac87c - There are now several pulls to fix this issue, I think they needs to be tested and consolidated first. They also need to be tested with the latest Arduino version too if you have not already? |
2 participants
Various changes to support vscode or fix a few issues I had.
I'm sorry about the reformatting; I'm new to vscode and not sure where to configure it. I dislike braces being on new lines by themselves, but do like consistency.