fix: potential crash on missing config file with unhandled exception#482
Open
zendy199x wants to merge 1 commit intotfeldmann:mainfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent CLI crashes when a config file can’t be found by adding explicit handling for ConfigNotFound around find_config() calls in the CLI entrypoints.
Changes:
- Wrapped
find_config()inConfigWithPath.by_name_or_path()with atry/except ConfigNotFoundthat prints an error and exits. - Added similar
ConfigNotFoundhandling to theedit()command. - Added similar
ConfigNotFoundhandling to theshow()command.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
I took another pass at the failing CI checks, but after 1 follow-up attempt(s) these checks are still failing: Cleanup artifacts. I'm closing this PR for now because the remaining failures look like they need manual investigation before the change can move forward. |
zendy199x
force-pushed
the
fix/potential-crash-on-missing-config-file-with-unhand
branch
from
07b4646 to
31ab5a2
Compare
- update organize/cli.py - address 1 review comment(s) Signed-off-by: Zendy <[email protected]>
zendy199x
force-pushed
the
fix/potential-crash-on-missing-config-file-with-unhand
branch
from
31ab5a2 to
edb86ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix potential crash on missing config file with unhandled exception. Added proper exception handling around
find_configcall to catchConfigNotFoundand provide a clear error message to the user before exiting.Related issue number
Checklist