Skip to content

Conversation

@NSant215
Copy link
Contributor

@NSant215 NSant215 commented Jan 16, 2026

Part of RV-862.
Closes RV-863.

What

Implement commit functionality on the Registry.

Why

required part of the interface.

How

  • The Registry is primarily the vector of databases.

  • a registry-commit is computed by:

    • committing each database and creating a vector of database hashes.
    • get the merkle root hash of the resulting vector
  • store registry commits alongside database commits i.e. commits/<registry-commit> is where it will be stored

  • the contents of this file will be the serialised vector of database hashes.

Manually Testing

make all

Tasks for the Author

  • Link all Linear issues related to this MR using magic words (e.g. part of, relates to, closes).
  • Eliminate dead code and other spurious artefacts introduced in your changes.
  • Document new public functions, methods and types.
  • Make sure the documentation for updated functions, methods, and types is correct.
  • Add tests for bugs that have been fixed.
  • Explain changes to regression test captures when applicable.
  • Write commit messages in agreement with our guidelines.
  • Self-review your changes to ensure they are high-quality.
  • Complete all of the above before assigning this MR to reviewers.

@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.29%. Comparing base (94b0af2) to head (d79d8dc).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
+ Coverage   91.26%   91.29%   +0.02%     
==========================================
  Files         108      108              
  Lines       20232    20232              
  Branches    20232    20232              
==========================================
+ Hits        18465    18470       +5     
+ Misses       1391     1386       -5     
  Partials      376      376              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NSant215 NSant215 force-pushed the santnr/registry-commit branch 18 times, most recently from f6a2181 to b7c4ee3 Compare January 23, 2026 13:34
@NSant215 NSant215 changed the title feat(dursto): Add commit and checkout operations to Registry feat(dursto): Add commit operation to Registry Jan 23, 2026
@NSant215 NSant215 force-pushed the santnr/registry-commit branch 6 times, most recently from b62b593 to 1936ec0 Compare January 23, 2026 15:09
@NSant215 NSant215 marked this pull request as ready for review January 23, 2026 15:15
@NSant215 NSant215 force-pushed the santnr/registry-commit branch 2 times, most recently from 870cb9d to f9a9ab4 Compare January 23, 2026 16:47
@NSant215 NSant215 requested a review from vapourismo January 23, 2026 16:49
@NSant215 NSant215 force-pushed the santnr/registry-commit branch from f9a9ab4 to 2f09c55 Compare January 23, 2026 17:19
@NSant215 NSant215 force-pushed the santnr/registry-commit branch 3 times, most recently from dd990a1 to c9edcfe Compare January 26, 2026 09:54
@NSant215 NSant215 enabled auto-merge January 26, 2026 10:27
@NSant215 NSant215 added this pull request to the merge queue Jan 26, 2026
@kurtisc kurtisc removed this pull request from the merge queue due to a manual request Jan 26, 2026
@kurtisc
Copy link
Contributor

kurtisc commented Jan 26, 2026

Sorry, I have review pending

@NSant215 NSant215 force-pushed the santnr/registry-commit branch 4 times, most recently from 8794ac4 to b8eb55d Compare January 26, 2026 11:41
@NSant215 NSant215 requested a review from kurtisc January 26, 2026 11:43
Copy link
Contributor

@kurtisc kurtisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as someone more familiar with the seq tree approves

@NSant215 NSant215 force-pushed the santnr/registry-commit branch from b8eb55d to d79d8dc Compare January 26, 2026 13:14
@NSant215 NSant215 enabled auto-merge January 26, 2026 13:17
@NSant215 NSant215 added this pull request to the merge queue Jan 26, 2026
Merged via the queue into main with commit 0b54205 Jan 26, 2026
8 checks passed
@NSant215 NSant215 deleted the santnr/registry-commit branch January 26, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants