-
Notifications
You must be signed in to change notification settings - Fork 4
feat(dursto): Add commit operation to Registry #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #718 +/- ##
==========================================
+ Coverage 91.26% 91.29% +0.02%
==========================================
Files 108 108
Lines 20232 20232
Branches 20232 20232
==========================================
+ Hits 18465 18470 +5
+ Misses 1391 1386 -5
Partials 376 376 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f6a2181 to
b7c4ee3
Compare
b62b593 to
1936ec0
Compare
870cb9d to
f9a9ab4
Compare
f9a9ab4 to
2f09c55
Compare
dd990a1 to
c9edcfe
Compare
|
Sorry, I have review pending |
8794ac4 to
b8eb55d
Compare
kurtisc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as someone more familiar with the seq tree approves
b8eb55d to
d79d8dc
Compare
Part of RV-862.
Closes RV-863.
What
Implement
commitfunctionality on the Registry.Why
required part of the interface.
How
The Registry is primarily the vector of databases.
a
registry-commitis computed by:store registry commits alongside database commits i.e.
commits/<registry-commit>is where it will be storedthe contents of this file will be the serialised vector of database hashes.
Manually Testing
Tasks for the Author