-
Notifications
You must be signed in to change notification settings - Fork 4
feat(dursto): write with offset in Database
#712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+149
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0c91db6 to
7c1bb3c
Compare
39e6e07 to
df90877
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #712 +/- ##
=======================================
Coverage 91.26% 91.27%
=======================================
Files 108 108
Lines 20232 20232
Branches 20232 20232
=======================================
+ Hits 18465 18466 +1
+ Misses 1391 1390 -1
Partials 376 376 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7c1bb3c to
eab2375
Compare
df90877 to
f410ae8
Compare
eab2375 to
aa97782
Compare
f410ae8 to
82ad8c5
Compare
aa97782 to
d11f309
Compare
9f3dc77 to
caef237
Compare
55d3e74 to
6bcaa72
Compare
caef237 to
2f1f9a0
Compare
6bcaa72 to
b890e04
Compare
af427da to
cedd8a3
Compare
b890e04 to
00cf6f2
Compare
cedd8a3 to
f5d3bc4
Compare
00cf6f2 to
bf3c916
Compare
5846a14 to
b32561d
Compare
bf3c916 to
4d0b654
Compare
b32561d to
84983a9
Compare
5cf8a85 to
e66fb34
Compare
84983a9 to
8bc3e3e
Compare
e66fb34 to
8825bda
Compare
8bc3e3e to
77a2658
Compare
feaee38 to
5c2eb4e
Compare
ebf2ef1 to
b7fb440
Compare
5c2eb4e to
aae2e92
Compare
b7fb440 to
9c11979
Compare
919ca98 to
2836d7f
Compare
b0fec71 to
4fc3c25
Compare
|
Benchmark results for revision 370dd10:
Full results
Compare the results above with those for the default branch. |
NSant215
reviewed
Jan 26, 2026
The new `set` API uses the cheaper value-replacing semantics.
4fc3c25 to
4986ee5
Compare
NSant215
approved these changes
Jan 26, 2026
vapourismo
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RV-834 and RV-844
What
Implements a write allowing updating an existing value.
Why
This is needed to support writes with an offset
How
Unifies #710 and #711
Splits the single
writefunction into awrite(with offset) andset(replacing).Manually Testing
No change to the benchmark
Tasks for the Author