Skip to content

#270 ADD Summary Comment#794

Closed
schonfinkel wants to merge 3 commits intomainfrom
270-ADD-Summary-Comment
Closed

#270 ADD Summary Comment#794
schonfinkel wants to merge 3 commits intomainfrom
270-ADD-Summary-Comment

Conversation

@schonfinkel
Copy link
Contributor

@schonfinkel schonfinkel commented Aug 29, 2025

Description

  • Small iterations to get something working atop of the new comment feature.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (explain):

Checklist

  • I have read the contributing guidelines
  • The pull request title follows this format:
    ISSUE_NUMBER ACTION_TYPE Short description (e.g., 123 ADD Feature description)
  • I have added tests and documentation (if applicable)
  • My changes generate no new warnings/errors and do not break existing functionality

Additional context (optional)

@schonfinkel schonfinkel self-assigned this Aug 29, 2025
@schonfinkel schonfinkel moved this to In Progress in The Senate Aug 29, 2025
@schonfinkel schonfinkel added the enhancement New feature or request label Aug 29, 2025
@schonfinkel schonfinkel force-pushed the 270-ADD-Summary-Comment branch from 0170b17 to d7c59f2 Compare September 2, 2025 12:21
@schonfinkel schonfinkel changed the title #720 ADD Summary Comment #270 ADD Summary Comment Sep 2, 2025
@schonfinkel schonfinkel force-pushed the 270-ADD-Summary-Comment branch 7 times, most recently from ea05e41 to d195980 Compare September 8, 2025 14:56
@schonfinkel schonfinkel force-pushed the 270-ADD-Summary-Comment branch 3 times, most recently from c7daae2 to 530aeb7 Compare September 15, 2025 19:33
@schonfinkel schonfinkel force-pushed the 270-ADD-Summary-Comment branch 4 times, most recently from b2083e1 to 0c5ff06 Compare September 20, 2025 13:03
@schonfinkel schonfinkel marked this pull request as ready for review September 22, 2025 14:32
@schonfinkel schonfinkel requested a review from a team as a code owner September 22, 2025 14:32
@terrateam-action

This comment has been minimized.

@terrateam-action

This comment has been minimized.

@terrateam-action

This comment has been minimized.

@schonfinkel schonfinkel force-pushed the 270-ADD-Summary-Comment branch from 88135b3 to 556c0a7 Compare September 23, 2025 14:52
@schonfinkel schonfinkel marked this pull request as draft September 23, 2025 14:52
@terrateam-action

This comment has been minimized.

@schonfinkel schonfinkel force-pushed the 270-ADD-Summary-Comment branch 2 times, most recently from 3a105b7 to 469edf8 Compare September 23, 2025 19:03
@schonfinkel schonfinkel force-pushed the 270-ADD-Summary-Comment branch 3 times, most recently from c3a3bdb to d915c81 Compare September 29, 2025 21:57
@schonfinkel schonfinkel marked this pull request as ready for review September 30, 2025 14:45
@terrateam-action

This comment has been minimized.

@schonfinkel schonfinkel force-pushed the 270-ADD-Summary-Comment branch from d915c81 to 8e4fbe1 Compare September 30, 2025 20:58
@terrateam-action

This comment has been minimized.

Comment on lines +527 to +540
let now = Unix.localtime (Unix.time ()) in
let pp_tm ppf t =
Format.fprintf
ppf
"%4d-%02d-%02dT%02d:%02d:%02dZ"
(t.Unix.tm_year + 1900)
(t.Unix.tm_mon + 1)
t.Unix.tm_mday
t.Unix.tm_hour
t.Unix.tm_min
t.Unix.tm_sec
in
let show_tm = Format.asprintf "%a" pp_tm in
let updated_timestamp = show_tm now in
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orbitz can you tell me later the TT way of doing it?

@schonfinkel schonfinkel force-pushed the 270-ADD-Summary-Comment branch from 8e4fbe1 to 34026e2 Compare October 2, 2025 19:48
@terrateam-action

This comment has been minimized.

@terrateam-action

This comment has been minimized.

@schonfinkel schonfinkel force-pushed the 270-ADD-Summary-Comment branch from 9e81409 to b57c99a Compare October 7, 2025 20:20
@terrateam-action
Copy link

Plans 👍

Outputs can be viewed in the Terrateam Console here.

Important

Gates added to the change.

Token Gates

Token Directory Workspace Required Approvers Any Approvers Any Remaining Count
code-commit-msg code default 1

These gates are fulfilled by commenting terrateam gate approve <token1> <token2> ... <tokenN>.

Expand for details on gates

What to do?

To continue, users matching the Required Approvers and Any Approvers must approve a token until all approvals are satisfied.

To approve a gate with a token, comment the following:

terrateam gate approve <token1> <token2> ... <tokenN>

Where <token> is the token to be approved.

To approve a gate without a token, approve the pull request.

How Gatekeeper requirements work

Gatekeeper uses all_of, any_of, and any_of_count to define approval rules:

  • all_of - Lists users or groups that must approve unconditionally.
  • any_of - Lists users or groups that may approve.
  • any_of_count - Sets how many approvals are required from the any_of list.

A gate is satisfied only when all conditions are met. See documentation for details.

Terrateam Plan Output 👍

Expand for plan output details

Dir: code | No changes

Dir: code
Workspace: default
Success: 👍

Step: run
Success: ✖️
Command: /github/workspace/bin/verify-commit-msg


Not all commit messages match the required structure
Commit messages must be of the form:

$GITHUB_ISSUE_1 $GITHUB_ISSUE_2 ... $GITHUB_ISSUE_N $ACTION $SUMMARY

OPTIONAL LONGER MESSAGE


Where:
$GITHUB_ISSUE can be of the form '#123' or 'org/repo#123'
$ACTION is ADD, REFACTOR, FIX, UPDATE, or REMOVE


For example:
#123 FIX Bug in confabulator that prevents users from making progress

The confabulator was working on a co-axial retrograde orientation when in reality
it necessary for it to be in a tri-axial prograde orientation.  This was preventing
users from verifying the semi-articulating socket pair.

Commit messages:
#270 wip Marcos Benevides
#270 ADD summary PR comment Marcos Benevides
#270 ADD PR summary comment migrations and queries Marcos Benevides

Step: plan
Success: 👍


To apply all these changes, comment:

terrateam apply

Feedback?

Questions? Comments? Give feedback by commenting terrateam feedback <your msg>. Your message lands directly in our inbox.

@schonfinkel schonfinkel moved this from In Progress to Next in The Senate Oct 15, 2025
@joshpollara joshpollara marked this pull request as draft January 6, 2026 10:55
@github-project-automation github-project-automation bot moved this from Next to Done in The Senate Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants