fix: retry getLogs with narrower range on max results exceeded#20
Merged
fix: retry getLogs with narrower range on max results exceeded#20
Conversation
When an RPC returns an error like: 'query exceeds max results 20000, retry with the range 24383075-24383096' The get_logs macro now automatically parses this error and retries with the suggested narrower block range, preventing test failures for queries that return too many logs. Added get_logs::get_logs_with_retry() helper that: - Attempts the initial get_logs request - Parses 'max results exceeded' errors for suggested range - Retries with the narrower filter if a range is found Amp-Thread-ID: https://ampcode.com/threads/T-019c28af-3499-7740-96b5-091785eeb259 Co-authored-by: Amp <[email protected]>
Amp-Thread-ID: https://ampcode.com/threads/T-019c28af-3499-7740-96b5-091785eeb259 Co-authored-by: Amp <[email protected]>
emmajam
approved these changes
Feb 4, 2026
mattsse
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an RPC returns an error like:
The
get_logsmacro now automatically parses this error and retries with the suggested narrower block range.Changes:
get_logs::get_logs_with_retry()helper that parses the error message and retries with the narrower rangeget_logs!macro to use this helperFixes the failing
get_logstests when block ranges contain too many logs.cc @mattsse @U0A34UN92HW