Add standalone activity validate token tests#8882
Merged
fretz12 merged 8 commits intotemporalio:mainfrom Jan 9, 2026
Merged
Conversation
… Refactored test layout. Update activity proto docs. Removed TODOs.
fretz12
force-pushed
the
fredtzeng/saa-validate-token-tests
branch
from
155e15d to
f84d121
Compare
bergundy
approved these changes
Jan 9, 2026
Member
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
Looks great, I skimmed most of the tests but the ones I read LGTM.
stephanos
pushed a commit
to stephanos/temporal
that referenced
this pull request
Jan 12, 2026
## What changed? - Added token validation tests for activity complete, fail, and cancel. Refactored test layout. - Update activity proto docs. Removed TODOs. - Changed activity closeTime and executionDuration to always be non-nil when the activity is in terminal state - Add validation on complete/fail/cancel/heartbeat token to ensure chasmRef namespace ID matches that of the request ## Why? As part of completing TODOs and cleanup of standalone activities. Any terminal state, including cancel, termination and timeout, should have a non-nil closeTime and executionDuration. We need to prevent any mismatches in request vs Token namespace. ## How did you test it? - [X] built - [X] run locally and tested manually - [X] covered by existing tests - [] added new unit test(s) - [X] added new functional test(s)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
As part of completing TODOs and cleanup of standalone activities.
Any terminal state, including cancel, termination and timeout, should have a non-nil closeTime and executionDuration.
We need to prevent any mismatches in request vs Token namespace.
How did you test it?