Update Chart to 0.68.2 and enhance SQL secret management.#763
Open
liorcic-huskeys wants to merge 2 commits intotemporalio:mainfrom
Open
Update Chart to 0.68.2 and enhance SQL secret management.#763liorcic-huskeys wants to merge 2 commits intotemporalio:mainfrom
liorcic-huskeys wants to merge 2 commits intotemporalio:mainfrom
Conversation
- Incremented chart version to 0.68.2. - Added support for secret references in SQL configuration, allowing for flexible management of connection parameters (host, port, database, user, password). - Deprecated existingSecret and secretName in favor of the new secretRef structure. - Updated templates to utilize secret references for environment variables in server deployment and configmap. This change improves security and flexibility in managing database credentials.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added flexible
secretRefconfiguration for SQL persistence connections that allows storing any combination of connection parameters (host, port, database, user, password) in Kubernetes secrets with automatic fallback to values.yaml for unspecified parameters.Key changes:
sql.secretRefconfiguration with optional keys:hostKey,portKey,databaseKey,userKey,passwordKeysecretRef.nameis specifiedexistingSecretandsecretNameas deprecated (maintained for backward compatibility)_helpers.tpl,server-deployment.yaml,server-configmap.yaml,_admintools-env.yamlWhy?
Currently, when using external Postgres databases, only the password can be stored in a secret (via
existingSecretorsecretName). All other connection parameters (host, port, database, user) must be hardcoded in values.yaml, which creates several problems:This change allows users to store all connection parameters in secrets while maintaining full backward compatibility with existing configurations.
Checklist
Closes [Feature Request] Add support for deploying and using PostgreSQL #637
How was this tested:
Test Scenario 1: Only password in secret
Test Scenario 2: All parameters from secret
Test Scenario 3: Mixed configuration
Test Scenario 4: Backward compatibility
existingSecretconfiguration still workssecretNameconfiguration still worksTest Scenario 5: Validation
secretRef.nameis set without any keysTest Scenario 6: Both stores (default and visibility)
secretRefon both default and visibility stores simultaneouslyAny docs updates needed?
Yes - values.yaml has been updated with comprehensive inline documentation:
existingSecretandsecretNamesecretRefstructureAdditional documentation updates recommended for docs.temporal.io:
secretRefexamplesexistingSecret/secretNametosecretRefExample Configuration (for documentation):
Where the secret is created by your database operator or secrets manager: