Allow usage of HPAs#708
Open
purkhusid wants to merge 3 commits intotemporalio:mainfrom
Open
Conversation
## What? Remove the default replica values of `1` since that clashes with the usage of HPAs. Instead default to not setting `replicas`, which by default is `1`.
Contributor
|
Makes sense. Please add a test. |
robholland
requested changes
Dec 18, 2025
| tag: 1.27.2 | ||
| pullPolicy: IfNotPresent | ||
| # Global default settings (can be overridden per service) | ||
| replicaCount: 1 |
Contributor
There was a problem hiding this comment.
Please leave this here (especially the comment). Just comment out the setting.
| labels: | ||
| {{- include "temporal.resourceLabels" (list $ "web" "deployment") | nindent 4 }} | ||
| spec: | ||
| {{- if .Values.web.replicaCount }} |
Contributor
There was a problem hiding this comment.
with is cleaner here to avoid repeating the setting path.
Author
|
@robholland This should be ready |
Contributor
|
There are still comments not attended to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Remove the default replica values of
1since that clashes with the usage of HPAs. Instead default to not settingreplicas, which by default is1.