Skip to content

[WIP] FIX logic in processOnChangeConditionForUpdateContext#4201

Open
fgalan wants to merge 2 commits intomasterfrom
fgalan-patch-1
Open

[WIP] FIX logic in processOnChangeConditionForUpdateContext#4201
fgalan wants to merge 2 commits intomasterfrom
fgalan-patch-1

Conversation

@fgalan
Copy link
Copy Markdown
Member

@fgalan fgalan commented Aug 26, 2022

@fgalan
Copy link
Copy Markdown
Member Author

fgalan commented Aug 31, 2022

In the first commit of this PR (73da133), test pass OK.

In the second commit (c803c4a), we update with master, thus introducing the new tests added in PR #4204.

 ----------- Failing tests ------------------
  o  0000_subs_attrs_deletion/delete_attribute_in_condition.test
  o  0000_subs_attrs_deletion/delete_attribute_in_empty_condition.test

In sum: removing && !caP->skip in the code causes a change in the Orion behaviour.

@fgalan
Copy link
Copy Markdown
Member Author

fgalan commented Aug 31, 2022

Looking into the failing tests:

imagen

Thus, the && !caP->skip is to preserve that attributes that doesn't have to be in the notification end there (as they has been deleted in the entity and the notification is supposed to show the current context information in the entity, not the deleted one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant