feat(bundler): add configurable detach retries for DMG creation#15212
Open
muratclk wants to merge 1 commit intotauri-apps:devfrom
Open
feat(bundler): add configurable detach retries for DMG creation#15212muratclk wants to merge 1 commit intotauri-apps:devfrom
muratclk wants to merge 1 commit intotauri-apps:devfrom
Conversation
Add `detachRetries` config option to `DmgConfig` that controls the maximum number of attempts to detach (unmount) the disk image during DMG creation. This helps users with large apps experiencing "hdiutil: detach: timeout" errors in CI environments. The value defaults to 3 (preserving current behavior) and can be configured via `tauri.conf.json` under `bundle.macOS.dmg.detachRetries`. Closes tauri-apps#14686 Co-Authored-By: Paperclip <noreply@paperclip.ing>
Contributor
Package Changes Through edcad49There are 10 changes which include tauri with minor, @tauri-apps/api with minor, tauri-macos-sign with patch, tauri-build with patch, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-bundler with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri-utils with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
detachRetriesconfiguration option toDmgConfigthat controls the maximum number of attempts to detach (unmount) the disk image during DMG creation. This addresses thehdiutil: detach: timeout for DiskArbitration expirederrors that occur in CI environments when building large apps (~400MB+ DMGs).Changes
detachRetriesfield toDmgConfig(tauri-utils) with a default of3(preserving current behavior)detach_retriesfield toDmgSettings(tauri-bundler)rust.rs)bundle_dmgshell script to readTAURI_DMG_DETACH_RETRIESenv var instead of hardcoded valueConfiguration
Users can set this in
tauri.conf.json:{ "bundle": { "macOS": { "dmg": { "detachRetries": 10 } } } }The default value of
3preserves backward compatibility. Users experiencing timeout issues (especially in CI with large apps) can increase this value.Closes #14686