Add Hytale service with Tailscale sidecar #191
Conversation
There was a problem hiding this comment.
Hi Alex,
Thank you for submitting your first pull request to this repository! I appreciate your contribution and hope it will be the first of many. I’ve added comments to the compose.yaml and .env files to align them with the template structure.
Please also update the README.md with Hytale.
Cheers!
|
|
||
| # Service Configuration | ||
| IMAGE_URL=deinfreu/hytale-server:experimental | ||
|
|
There was a problem hiding this comment.
Please add the SERVICE variable. This will ensure that the application container is named app-${SERVICE}, and the Tailscale container is named tailscale-${SERVICE}.
| # Make sure you have updated/checked the .env file with the correct variables. | ||
| # All the ${ xx } need to be defined there. | ||
| # Tailscale Sidecar Configuration | ||
| hytale-ts: |
There was a problem hiding this comment.
In the template, we use 'tailscale'. While this does not affect functionality, it represents a deviation from the template structure. I recommend changing it to 'tailscale' for consistency.
| # Tailscale Sidecar Configuration | ||
| hytale-ts: | ||
| image: tailscale/tailscale:latest # Image to be used | ||
| container_name: hytale-ts # Name for local container management |
There was a problem hiding this comment.
If the SERVICE variable is defined, I recommend setting 'container_name: tailscale-${SERVICE}' instead.
| restart: always | ||
|
|
||
| # ${SERVICE} | ||
| hytale-server: |
There was a problem hiding this comment.
In the template, we use 'application'. While this does not affect functionality, it represents a deviation from the template structure. I recommend changing it to 'application' for consistency.
| hytale-server: | ||
| image: ${IMAGE_URL} # Image to be used | ||
| network_mode: service:tailscale # Sidecar configuration to route ${SERVICE} through Tailscale | ||
| container_name: hytale-server # Name for local container management |
There was a problem hiding this comment.
If the SERVICE variable is defined, I recommend setting 'container_name: app-${SERVICE}' instead.
README.