Open
Conversation
Member
Author
|
@MassivDash Could you test this PR, please? |
Contributor
|
I just saw the changes you made, I'll test them out soon and let you know |
Contributor
|
So, I have tested this version, but unfortunately, it does not work correctly without somekind of passwordHash inserted into a table. Without the passwordHash, the csrf token gets created but the JSON web token gets an error. With whatever passwordHash in the user table, it works correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Fixes session absence on social logins
How did you fix it?
grantAccess used passwordHash as a part of a refresh secret key. Since passwordHash were not set by registerUser it was sometimes null, sometimes undefined and session was invalidated because of that. I'm using identityId instead of passwordHash, which should be unique and always defined.