Strip subnet mask from HetznerBareMetalHost IP Address#1696
Strip subnet mask from HetznerBareMetalHost IP Address#1696Strangerxxx wants to merge 1 commit intosyself:v1.1.xfrom
Conversation
d941c23 to
a7fb2b7
Compare
|
@Strangerxxx looks good. But please elaborate the PR description first. Please provide an example of the current and the new IP |
|
@guettli thank you for review! I've add examples you've asked for. Please let me know what else should be done. I'm happy to fix it asap :) |
|
@Strangerxxx I know that the term "IP" does not match the content ( If you are looking for the IP, then you can use You propose a change to Currently, I am slightly against this change, because I have concerns that removing Please elaborate your current pain point, and how this PR would help. |
What this PR does / why we need it:
It basically strips subnet mask suffix from the NIC IP for BaremetalHost, so it became correctly recognized as IP by other providers of ClusterAPI ecosystem.
Previously IP was a string like:
37.27.255.255/16After this changes IP will become a string
37.27.255.255TODOs: