Conversation
|
I think this also means the workspace is redundant? |
|
This looks good to me, didn't know there was a new native dependency manager to reference directly. The sparkle dependency was almost never touched and I played with cacoapods for a bit. I would also better see sparkle updated to the latest greatest version then. But not sure if it breaks compatibility or not running on macOS 12. We need at least macOS 12 because of syncthing daemon itself. Not sure about the workspace, i'm not a big XCode guru as I mostly do lowlevel programming. |
|
I don't think the changes to 2.x are much trouble, but that's a problem for another day! :) |
|
Let's goooo 🚀 |
|
You broke the build: |
|
Probably the Makefile must be update to not build the missing XCode target. It's also a little my fault because the v2 default branch pull requests are not checked before merge. It seems the Sparkle dependency is implicit build by the new implementation. |
The entire use of cocoapods (which is only for one dependency) can be entirely removed by just embedding Sparkle using swift package manager.
I only spent about 30 seconds on this, but looks like it works fine!
I couldn't figure out anywhere in the code/podfiles that specified a version, but
1.27.3seems to work.Also updated the
gitignoreto remove allxcuserdatafolders, these shouldn't be commited. (That should have been a seperate PR, but realised too late when my gitclient removed the tracked files)